fix: fix ddl client can not update leader addr #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengjiachun
reviewed
Aug 18, 2023
WenyXu
force-pushed
the
fix/fix-ddl-client
branch
from
dc60ded to
8e48010
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2205 +/- ##
===========================================
- Coverage 84.65% 84.21% -0.45%
===========================================
Files 700 700
Lines 112678 112742 +64
===========================================
- Hits 95390 94942 -448
- Misses 17288 17800 +512 |
killme2008
reviewed
Aug 21, 2023
WenyXu
force-pushed
the
fix/fix-ddl-client
branch
from
6746454 to
556682e
Compare
WenyXu
force-pushed
the
fix/fix-ddl-client
branch
from
556682e to
3c77074
Compare
waynexia
approved these changes
Aug 21, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* fix: fix ddl client can not update leader addr * chore: apply suggestions from CR * feat: add message to context * fix: only retry if unavailable or deadline exceeded * chore: apply suggestions from CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Fix DDL client can not update leader address
Checklist
Refer to a related PR or issue link (optional)