feat: impl duration datatype and vectors #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2180 +/- ##
===========================================
- Coverage 77.44% 77.41% -0.04%
===========================================
Files 726 728 +2
Lines 114219 114939 +720
===========================================
+ Hits 88461 88976 +515
- Misses 25758 25963 +205 |
2 tasks
|
@QuenKar Thanks for your PR. Is this PR ready for review? If so, there are some conflicts that have to be resolved. |
QuenKar
force-pushed
the
feat/duration-datatype
branch
2 times, most recently
from
dfffb09 to
50e60e4
Compare
|
@killme2008 thx, I resolved the conflicts, please take a look. |
2 tasks
|
@waynexia Please take a look |
evenyag
reviewed
Sep 13, 2023
QuenKar
force-pushed
the
feat/duration-datatype
branch
2 times, most recently
from
e45a0f7 to
da7f51d
Compare
QuenKar
force-pushed
the
feat/duration-datatype
branch
from
da7f51d to
c937bb9
Compare
|
@evenyag If you have time, please take a look(•̀ᴗ• ) |
Co-authored-by: Yingwen <[email protected]>
QuenKar
force-pushed
the
feat/duration-datatype
branch
from
c937bb9 to
493d32c
Compare
evenyag
approved these changes
Sep 18, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: impl datatype, vector traits for duration. * feat: duration and grpc. * test: add unit test cases. * chore: style and test case. * fix: update greptime-proto version and helper.rs * chore: fix type name. * Update src/datatypes/src/data_type.rs Co-authored-by: Yingwen <[email protected]> * chore: cr. * chore: fix greptime-proto --------- Co-authored-by: Yingwen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Main change:
DurationTypeinsrc/datatypes/src/types.Durationtype, we can useDurationSecondVector,DurationMillisecondVectoretc.Durationand gRPC, JSON, arrow duration arrays, ScalarValue etc.Checklist
Refer to a related PR or issue link (optional)