feat(mito): Defines the read Batch struct for mito2 #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenyag
force-pushed
the
feat/mito2-batch
branch
from
99dff0a to
84867de
Compare
evenyag
force-pushed
the
feat/mito2-batch
branch
from
84867de to
a46f262
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2174 +/- ##
===========================================
- Coverage 85.03% 84.58% -0.45%
===========================================
Files 698 696 -2
Lines 111719 111810 +91
===========================================
- Hits 94995 94574 -421
- Misses 16724 17236 +512 |
40 tasks
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: define batch * feat: define Batch struct * feat: stream writer takes arrow's types * feat: make it compile * feat: use uint64vector and uint8vector * feat: add timestamps and primary key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Defines the new read Batch struct. This struct can hold rows for the same time series.
It also replaces
SchemaRefandBatchinBufferedWriterwith arrow'sSchemaRefandRecordBatch. I plan to implement the conversion betweenBatchandRecordBatchoutside of theBufferedWriter.Checklist
Refer to a related PR or issue link (optional)