feat(mito): Write wal and memtable #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2135 +/- ##
===========================================
- Coverage 84.90% 84.56% -0.34%
===========================================
Files 696 696
Lines 110614 111042 +428
===========================================
- Hits 93915 93907 -8
- Misses 16699 17135 +436 |
waynexia
reviewed
Aug 10, 2023
evenyag
force-pushed
the
feat/mito2-write-wal
branch
from
027b153 to
d2b0097
Compare
waynexia
reviewed
Aug 12, 2023
evenyag
force-pushed
the
feat/mito2-write-wal
branch
from
d2b0097 to
1e9f5bf
Compare
waynexia
approved these changes
Aug 12, 2023
40 tasks
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: hold wal entry in RegionWriteCtx * feat: entry id and commited sequence * feat: write to wal * feat: write memtable * feat: fill missing columns * feat: validate write request * feat: more validation to write request * chore: fix typos * feat: remove init and validate rows in new() * style: fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR writes data into WAL and memtables. It validates write requests before writing them.
The worker collects requests from different regions and writes them to the WAL in one batch.
To handle schema change, it fills default values before sending the request to the writer. Inside the writer, if the request still misses some columns, the writer pads default values again. This is possible if the write request comes during altering schema.
Checklist
Refer to a related PR or issue link (optional)