Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mito): Implement open and close for mito2 regions #2052

Merged
merged 9 commits into from
Aug 1, 2023
Merged

feat(mito): Implement open and close for mito2 regions #2052

merged 9 commits into from
Aug 1, 2023

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Jul 31, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR implements open_region and close_region for mito2 engine.

It also stops all regions while stopping the engine.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag force-pushed the feat/mito2-open-close branch from e94039c to 9f6ce4b Compare July 31, 2023 12:59
@evenyag evenyag marked this pull request as ready for review July 31, 2023 13:00
waynexia
waynexia reviewed Jul 31, 2023
View reviewed changes
src/mito2/src/worker/handle_close.rs Outdated Show resolved Hide resolved
src/mito2/src/worker.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Merging #2052 (2e3de9f) into develop (bddaf26) will decrease coverage by 0.31%.
Report is 2 commits behind head on develop.
The diff coverage is 88.70%.

❗ Current head 2e3de9f differs from pull request most recent head 95fcfeb. Consider uploading reports for the commit 95fcfeb to get more accurate results

@@             Coverage Diff             @@
##           develop    #2052      +/-   ##
===========================================
- Coverage    85.17%   84.86%   -0.31%     
===========================================
  Files          672      673       +1     
  Lines       105988   106327     +339     
===========================================
- Hits         90277    90239      -38     
- Misses       15711    16088     +377

@evenyag evenyag requested review from v0y4g3r and waynexia August 1, 2023 03:17
@evenyag evenyag self-assigned this Aug 1, 2023
killme2008
killme2008 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Aug 1, 2023
Merged via the queue into GreptimeTeam:develop with commit c529c8a Aug 1, 2023
@evenyag evenyag mentioned this pull request Jul 24, 2023
Closed
40 tasks
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@evenyag @paomian
feat(mito): Implement open and close for mito2 regions (GreptimeTeam#…
e051346 
…2052)

* feat: add close request

* feat: handle close and open request

* feat: Implement open

* test: add TestEnv::new

* feat: close region/engine and test

* style: fix clippy

* style: import log macros

* docs: update docs

* docs: add mermaid for manifest manager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@killme2008 killme2008 killme2008 approved these changes

@v0y4g3r v0y4g3r Awaiting requested review from v0y4g3r

Assignees

@evenyag evenyag

Labels
None yet
Projects
mito2
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evenyag @killme2008 @waynexia