fix: checkpoint metadata file dirty caching #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynexia
approved these changes
Jul 24, 2023
evenyag
approved these changes
Jul 24, 2023
Codecov Report
@@ Coverage Diff @@
## develop #2020 +/- ##
===========================================
- Coverage 85.44% 85.07% -0.38%
===========================================
Files 659 659
Lines 104423 104441 +18
===========================================
- Hits 89228 88855 -373
- Misses 15195 15586 +391 |
shuiyisong
pushed a commit
that referenced
this pull request
Jul 24, 2023
fix: dirty last checkpoint metadata file when enable object store caching, #2013
shuiyisong
pushed a commit
that referenced
this pull request
Aug 9, 2023
fix: dirty last checkpoint metadata file when enable object store caching, #2013
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
fix: dirty last checkpoint metadata file when enable object store caching, GreptimeTeam#2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Don't cache
__last_checkpointfile when enabling object store cache. It would cause SST files metadata error in region just like #2013Checklist
Refer to a related PR or issue link (optional)
Close #2013