feat(mito): create region in mito2 engine #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenyag
force-pushed
the
feat/create-mito2-region
branch
from
ea3db4e to
a438252
Compare
40 tasks
waynexia
reviewed
Jul 20, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1999 +/- ##
===========================================
- Coverage 85.71% 85.56% -0.15%
===========================================
Files 647 650 +3
Lines 102866 103095 +229
===========================================
+ Hits 88167 88214 +47
- Misses 14699 14881 +182 |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* chore: check table existence * refactor: rename LevelMetaVec * feat: create request to metadata * refactor: Share MitoConfig between workers * feat: impl handle_create_request * refactor: move tests mod * feat: validate time index nullable * feat: test create region * feat: test create if not exists * feat: remove option * style: fix clippy * chore: address CR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements
create_region()for the mito2 engine.Checklist
Refer to a related PR or issue link (optional)