feat(mito): Define Version and metadata builders for mito2 #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1989 +/- ##
===========================================
- Coverage 85.77% 85.38% -0.40%
===========================================
Files 639 642 +3
Lines 102727 103143 +416
===========================================
- Hits 88116 88067 -49
- Misses 14611 15076 +465 |
waynexia
approved these changes
Jul 19, 2023
40 tasks
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…eam#1989) * feat: define structs for version * feat: Build region from metadata and memtable builder * feat: impl validate for metadata * feat: add more fields to RegionMetadata * test: more tests * test: more check and test * feat: allow overwriting version * style: fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR defines the following structs to hold region metadata in memory:
LevelMetas)It also implements some builders to build structs like
RegionMetadata. The builder usevalidate()method defined inColumnMetadataandRegionMetadatato check whether the struct is valid.It also checks whether a column in the
Schemais unique.Checklist
Refer to a related PR or issue link (optional)