Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the stdout log appender configurable #2995

Closed
MichaelScofield opened this issue Dec 25, 2023 · 0 comments · Fixed by #3003
Closed

Make the stdout log appender configurable #2995

MichaelScofield opened this issue Dec 25, 2023 · 0 comments · Fixed by #3003
Labels
good first issue Good for newcomers

Comments

@MichaelScofield
Copy link
Collaborator

What type of enhancement is this?

Configuration

What does the enhancement do?

Logging to stdout makes the log rotation out of the control of GreptimeDB, which could make file system exploded especially in the situation that GreptimeDB is started by systemd and the journald is not properly configured. So I think it's better to make the stdout log appender configurable, users could remove the behavior of logging to stdout. Of course for the ease of use, logging to stdout is enable by default.

Implementation challenges

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants