Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for "if exists" clause for drop table #2794

Closed
sunng87 opened this issue Nov 23, 2023 · 1 comment · Fixed by #2859
Closed

Add support for "if exists" clause for drop table #2794

sunng87 opened this issue Nov 23, 2023 · 1 comment · Fixed by #2859
Assignees
@zuston
Labels
C-enhancement Category Enhancements good first issue Good for newcomers

Comments

@sunng87
Copy link
Member

sunng87 commented Nov 23, 2023

What type of enhancement is this?

API improvement

What does the enhancement do?

https://dev.mysql.com/doc/refman/8.0/en/drop-table.html

DROP TABLE IF EXISTS <table> allows us safely drop a table even if it is not created before.

Implementation challenges

No response
@sunng87 sunng87 added C-enhancement Category Enhancements good first issue Good for newcomers Difficulty: Easy labels Nov 23, 2023
@zuston
Copy link

zuston commented Nov 23, 2023

I want to pick up this. @sunng87

zuston added a commit to zuston/greptime-proto that referenced this issue Nov 23, 2023
@zuston
feat: add IF EXISTS for DROP
167dfec 
For GreptimeTeam/greptimedb#2794
@zuston zuston mentioned this issue Nov 23, 2023
Merged
2 tasks
waynexia added a commit to GreptimeTeam/greptime-proto that referenced this issue Nov 24, 2023
@zuston @waynexia
feat: add IF EXISTS for DROP (#123)
2aaee38 
* feat: add IF EXISTS for DROP

For GreptimeTeam/greptimedb#2794

* generate code

Signed-off-by: Ruihang Xia <[email protected]>

---------

Signed-off-by: Ruihang Xia <[email protected]>
Co-authored-by: Ruihang Xia <[email protected]>
@tisonkun tisonkun mentioned this issue Dec 2, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zuston zuston

Labels
C-enhancement Category Enhancements good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: drop if exists
2 participants
@sunng87 @zuston