Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance sqlness harness to accept a connection string #2635

Closed
waynexia opened this issue Oct 23, 2023 · 0 comments · Fixed by #2692
Closed

Enhance sqlness harness to accept a connection string #2635

waynexia opened this issue Oct 23, 2023 · 0 comments · Fixed by #2692
Labels
C-feature Category Features good first issue Good for newcomers

Comments

@waynexia
Copy link
Member

What problem does the new feature solve?

Our sqlness harness (cargo sqlness) will start its db process for testing. It's helpful to make it able to accept a connection string and run cases on a remote db instance.

E.g.:

cargo sqlness --host 127.0.0.1 --port 3306

What does the feature do?

Add two new cli options --host/-h and --port/-p to sqlness cli. And skip starting the db process if a remote address is provided.

Notice that the RESTART command won't work under this mode. We can simply ignore it and emit a log

Implementation challenges

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category Features good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant