Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tests/cases/distributed/show and tests/cases/standalone/show to common dir #2500

Closed
WenyXu opened this issue Sep 26, 2023 · 1 comment · Fixed by #2748
Closed

Move tests/cases/distributed/show and tests/cases/standalone/show to common dir #2500

WenyXu opened this issue Sep 26, 2023 · 1 comment · Fixed by #2748
Assignees
@poltao
Labels
C-enhancement Category Enhancements good first issue Good for newcomers

Comments

@WenyXu
Copy link
Member

WenyXu commented Sep 26, 2023

What type of enhancement is this?

Tech debt reduction

What does the enhancement do?

Now, the standalone also supports to creation of multiple regions table, therefore we can move tests/cases/distributed/show and tests/cases/standalone/show to the common dir (tests/cases/standalone(distributed)/common)

Implementation challenges

No response
@WenyXu WenyXu added C-enhancement Category Enhancements good first issue Good for newcomers labels Sep 26, 2023
@poltao
Copy link
Contributor

poltao commented Nov 8, 2023

@WenyXu Hi, I'm a newbie. Can I try this?

@poltao poltao mentioned this issue Nov 14, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poltao poltao

Labels
C-enhancement Category Enhancements good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: move sqlness env show test to common dir poltao/greptimedb
2 participants
@WenyXu @poltao