Skip to content

Commit

Permalink
chore: per review
Browse files Browse the repository at this point in the history
  • Loading branch information
discord9 committed Feb 21, 2024
1 parent 24d2d50 commit f106fc8
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions src/flow/src/expr/scalar.rs
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ impl ScalarExpr {
}

/// Returns the set of columns that are referenced by `self`.
pub fn support(&self) -> BTreeSet<usize> {
pub fn get_all_ref_columns(&self) -> BTreeSet<usize> {
let mut support = BTreeSet::new();
self.visit_post_nolimit(&mut |e| {
if let ScalarExpr::Column(i) = e {
Expand Down Expand Up @@ -280,13 +280,6 @@ impl ScalarExpr {
mut expr2,
} = self.clone()
{
let expr_1_contains_now = expr1.contains_temporal();
let expr_2_contains_now = expr2.contains_temporal();

if !(expr_1_contains_now ^ expr_2_contains_now) {
return unsupported_err("one side of the comparison must be `now()`");
}

// TODO: support simple transform like `now() + a < b` to `now() < b - a`

let expr1_is_now =
Expand Down

0 comments on commit f106fc8

Please sign in to comment.