Skip to content

Commit

Permalink
Update install.sh (#517)
Browse files Browse the repository at this point in the history
  • Loading branch information
@zyy17
zyy17 authored Nov 15, 2022
1 parent 6c6eeda commit b93c084
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/install.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ARCH_TYPE=
VERSION=${1:-latest}
GITHUB_ORG=GreptimeTeam
GITHUB_REPO=greptimedb
BIN=greptimedb
BIN=greptime

get_os_type() {
os_type="$(uname -s)"
Expand Down

3 comments on commit b93c084

@Explosion-Scratch
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no conventional commits?

@zyy17
Copy link
Collaborator Author

@zyy17 zyy17 commented on b93c084 Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Explosion-Scratch Thanks for your notice, you really got me. The original PR (#517) is conventional commits but I edit the file from GitHub web page(maybe that's the reason why the final commit title looks wired). The same thing happen in bf408e3. We will pay more attention next time.

@evenyag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created issue #567 for this

Please sign in to comment.