fix: only alter writable region

GreptimeTeam · Sep 13, 2023 · b5fb517 · b5fb517
1 parent 0e8a2c6
commit b5fb517
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/src/mito2/src/region.rs b/src/mito2/src/region.rs
@@ -135,19 +135,6 @@ impl RegionMap {
         regions.get(&region_id).cloned()
     }
 
-    /// Gets region by region id or call the failure callback.
-    pub(crate) fn get_region_or<F: OnFailure>(
-        &self,
-        region_id: RegionId,
-        cb: &mut F,
-    ) -> Option<MitoRegionRef> {
-        let region_opt = self.get_region(region_id);
-        if region_opt.is_none() {
-            cb.on_failure(RegionNotFoundSnafu { region_id }.build());
-        }
-        region_opt
-    }
-
     /// Gets writable region by region id.
     ///
     /// Returns error if the region does not exist or is readonly.

diff --git a/src/mito2/src/worker/handle_alter.rs b/src/mito2/src/worker/handle_alter.rs
@@ -39,7 +39,7 @@ impl<S> RegionWorkerLoop<S> {
         request: RegionAlterRequest,
         mut sender: OptionOutputTx,
     ) {
-        let Some(region) = self.regions.get_region_or(region_id, &mut sender) else {
+        let Some(region) = self.regions.writable_region_or(region_id, &mut sender) else {
             return;
         };