fix: fix non-physical error msg (#3087)

GreptimeTeam · Jan 3, 2024 · b2b7523 · b2b7523
1 parent aa22f9c
commit b2b7523
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 11 deletions.
diff --git a/src/common/meta/src/key/table_route.rs b/src/common/meta/src/key/table_route.rs
@@ -66,7 +66,7 @@ impl TableRouteValue {
         ensure!(
             self.is_physical(),
             UnexpectedLogicalRouteTableSnafu {
-                err_msg: "{self:?} is a non-physical TableRouteValue.",
+                err_msg: format!("{self:?} is a non-physical TableRouteValue."),
             }
         );
         let version = self.physical_table_route().version;
@@ -84,7 +84,7 @@ impl TableRouteValue {
         ensure!(
             self.is_physical(),
             UnexpectedLogicalRouteTableSnafu {
-                err_msg: "{self:?} is a non-physical TableRouteValue.",
+                err_msg: format!("{self:?} is a non-physical TableRouteValue."),
             }
         );
         Ok(self.physical_table_route().version)
@@ -95,7 +95,7 @@ impl TableRouteValue {
         ensure!(
             self.is_physical(),
             UnexpectedLogicalRouteTableSnafu {
-                err_msg: "{self:?} is a non-physical TableRouteValue.",
+                err_msg: format!("{self:?} is a non-physical TableRouteValue."),
             }
         );
         Ok(self
@@ -116,7 +116,7 @@ impl TableRouteValue {
         ensure!(
             self.is_physical(),
             UnexpectedLogicalRouteTableSnafu {
-                err_msg: "{self:?} is a non-physical TableRouteValue.",
+                err_msg: format!("{self:?} is a non-physical TableRouteValue."),
             }
         );
         Ok(&self.physical_table_route().region_routes)

diff --git a/src/meta-srv/src/procedure/region_failover/update_metadata.rs b/src/meta-srv/src/procedure/region_failover/update_metadata.rs
@@ -89,7 +89,7 @@ impl UpdateRegionMetadata {
         let mut new_region_routes = table_route_value
             .region_routes()
             .context(error::UnexpectedLogicalRouteTableSnafu {
-                err_msg: "{self:?} is a non-physical TableRouteValue.",
+                err_msg: format!("{self:?} is a non-physical TableRouteValue."),
             })?
             .clone();
 

diff --git a/src/meta-srv/src/procedure/region_migration/manager.rs b/src/meta-srv/src/procedure/region_migration/manager.rs
@@ -256,7 +256,7 @@ impl RegionMigrationManager {
         let region_route = table_route
             .region_route(region_id)
             .context(error::UnexpectedLogicalRouteTableSnafu {
-                err_msg: "{self:?} is a non-physical TableRouteValue.",
+                err_msg: format!("{table_route:?} is a non-physical TableRouteValue."),
             })?
             .context(error::RegionRouteNotFoundSnafu { region_id })?;
 

diff --git a/src/meta-srv/src/procedure/region_migration/migration_start.rs b/src/meta-srv/src/procedure/region_migration/migration_start.rs
@@ -86,7 +86,7 @@ impl RegionMigrationStart {
         let region_route = table_route
             .region_routes()
             .context(error::UnexpectedLogicalRouteTableSnafu {
-                err_msg: "{self:?} is a non-physical TableRouteValue.",
+                err_msg: format!("{self:?} is a non-physical TableRouteValue."),
             })?
             .iter()
             .find(|route| route.region.id == region_id)

diff --git a/src/meta-srv/src/procedure/region_migration/update_metadata/upgrade_candidate_region.rs b/src/meta-srv/src/procedure/region_migration/update_metadata/upgrade_candidate_region.rs
@@ -33,7 +33,7 @@ impl UpdateMetadata {
         let mut region_routes = table_route_value
             .region_routes()
             .context(error::UnexpectedLogicalRouteTableSnafu {
-                err_msg: "{self:?} is a non-physical TableRouteValue.",
+                err_msg: format!("{self:?} is a non-physical TableRouteValue."),
             })?
             .clone();
         let region_route = region_routes
@@ -86,7 +86,7 @@ impl UpdateMetadata {
         let region_routes = table_route_value
             .region_routes()
             .context(error::UnexpectedLogicalRouteTableSnafu {
-                err_msg: "{self:?} is a non-physical TableRouteValue.",
+                err_msg: format!("{self:?} is a non-physical TableRouteValue."),
             })?
             .clone();
         let region_route = region_routes

diff --git a/src/partition/src/manager.rs b/src/partition/src/manager.rs
@@ -79,7 +79,7 @@ impl PartitionRuleManager {
             route
                 .region_routes()
                 .context(error::UnexpectedLogicalRouteTableSnafu {
-                    err_msg: "{self:?} is a non-physical TableRouteValue.",
+                    err_msg: format!("{route:?} is a non-physical TableRouteValue."),
                 })?;
         Ok(RegionRoutes(region_routes.clone()))
     }
@@ -96,7 +96,7 @@ impl PartitionRuleManager {
             route
                 .region_routes()
                 .context(error::UnexpectedLogicalRouteTableSnafu {
-                    err_msg: "{self:?} is a non-physical TableRouteValue.",
+                    err_msg: format!("{route:?} is a non-physical TableRouteValue."),
                 })?;
 
         ensure!(