refactor: remove sequence number from ScanRequest (#2785)

Signed-off-by: Ruihang Xia <[email protected]>
GreptimeTeam · Nov 21, 2023 · 99dbb74 · 99dbb74
1 parent a7bbd61
commit 99dbb74
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 9 deletions.
diff --git a/src/metric-engine/src/metadata_region.rs b/src/metric-engine/src/metadata_region.rs
@@ -262,7 +262,6 @@ impl MetadataRegion {
         let filter_expr = col(METADATA_SCHEMA_KEY_COLUMN_NAME).eq(lit(key));
 
         ScanRequest {
-            sequence: None,
             projection: Some(vec![METADATA_SCHEMA_VALUE_COLUMN_INDEX]),
             filters: vec![filter_expr.into()],
             output_ordering: None,
@@ -390,7 +389,6 @@ mod test {
         let key = "test_key";
         let expected_filter_expr = col(METADATA_SCHEMA_KEY_COLUMN_NAME).eq(lit(key));
         let expected_scan_request = ScanRequest {
-            sequence: None,
             projection: Some(vec![METADATA_SCHEMA_VALUE_COLUMN_INDEX]),
             filters: vec![expected_filter_expr.into()],
             output_ordering: None,

diff --git a/src/mito2/src/engine/projection_test.rs b/src/mito2/src/engine/projection_test.rs
@@ -74,7 +74,6 @@ async fn test_scan_projection() {
 
     // Scans tag_1, field_1, ts
     let request = ScanRequest {
-        sequence: None,
         projection: Some(vec![1, 3, 4]),
         filters: Vec::new(),
         output_ordering: None,

diff --git a/src/store-api/src/storage/requests.rs b/src/store-api/src/storage/requests.rs
@@ -26,7 +26,7 @@ use snafu::{OptionExt, ResultExt};
 use crate::error::{
     BuildColumnDescriptorSnafu, Error, InvalidDefaultConstraintSnafu, InvalidRawRegionRequestSnafu,
 };
-use crate::storage::{ColumnDescriptor, ColumnDescriptorBuilder, RegionDescriptor, SequenceNumber};
+use crate::storage::{ColumnDescriptor, ColumnDescriptorBuilder, RegionDescriptor};
 
 /// Write request holds a collection of updates to apply to a region.
 ///
@@ -48,11 +48,6 @@ pub trait WriteRequest: Send {
 
 #[derive(Default, Clone, Debug, PartialEq, Eq)]
 pub struct ScanRequest {
-    /// Max sequence number to read, None for latest sequence.
-    ///
-    /// Default is None. Only returns data whose sequence number is less than or
-    /// equal to the `sequence`.
-    pub sequence: Option<SequenceNumber>,
     /// Indices of columns to read, `None` to read all columns.
     pub projection: Option<Vec<usize>>,
     /// Filters pushed down