Apply suggestions from code review

Co-authored-by: niebayes <[email protected]>
GreptimeTeam · Jan 6, 2024 · 865afc6 · 865afc6
1 parent 38b90a3
commit 865afc6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/log-store/src/kafka/util/record.rs b/src/log-store/src/kafka/util/record.rs
@@ -300,6 +300,7 @@ mod tests {
     use super::*;
     use crate::kafka::client_manager::ClientManager;
     use crate::kafka::util::test_util::run_test_with_kafka_wal;
+
     // Implements some utility methods for testing.
     impl Default for Record {
         fn default() -> Self {

diff --git a/src/log-store/src/kafka/util/test_util.rs b/src/log-store/src/kafka/util/test_util.rs
@@ -21,11 +21,10 @@ pub async fn run_test_with_kafka_wal<F>(test: F)
 where
     F: FnOnce(Vec<String>) -> BoxFuture<'static, ()>,
 {
-    let endpoints = env::var("GT_KAFKA_ENDPOINTS").unwrap_or_default();
-    if endpoints.is_empty() {
+    let Ok(endpoints) = env::var("GT_KAFKA_ENDPOINTS") else {
         warn!("The endpoints is empty, skipping the test");
         return;
-    }
+    };
 
     let endpoints = endpoints
         .split(',')