chore: remove remark_inactive_region field

GreptimeTeam · Nov 13, 2023 · 80e6049 · 80e6049
1 parent 8ee7682
commit 80e6049
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/src/meta-srv/src/procedure/region_failover.rs b/src/meta-srv/src/procedure/region_failover.rs
@@ -270,8 +270,6 @@ trait State: Sync + Send + Debug {
     fn status(&self) -> Status {
         Status::executing(true)
     }
-
-    fn remark_inactive_region_if_needed(&mut self) {}
 }
 
 /// The states transition of region failover procedure:
@@ -341,11 +339,7 @@ impl RegionFailoverProcedure {
     }
 
     fn from_json(json: &str, context: RegionFailoverContext) -> ProcedureResult<Self> {
-        let mut node: Node = serde_json::from_str(json).context(FromJsonSnafu)?;
-        // If the meta leader node dies during the execution of the procedure,
-        // the new leader node needs to remark the failed region as "inactive"
-        // to prevent it from renewing the lease.
-        node.state.remark_inactive_region_if_needed();
+        let node: Node = serde_json::from_str(json).context(FromJsonSnafu)?;
         Ok(Self { node, context })
     }
 }

diff --git a/src/meta-srv/src/procedure/region_failover/activate_region.rs b/src/meta-srv/src/procedure/region_failover/activate_region.rs
@@ -176,10 +176,6 @@ impl State for ActivateRegion {
 
         self.handle_response(mailbox_receiver, failed_region).await
     }
-
-    fn remark_inactive_region_if_needed(&mut self) {
-        self.remark_inactive_region = true;
-    }
 }
 
 #[cfg(test)]