Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: some comments
Browse files Browse the repository at this point in the history
v0y4g3r committed Dec 18, 2024
1 parent 6239f8c commit 7d9d93e
Showing 3 changed files with 3 additions and 10 deletions.
9 changes: 0 additions & 9 deletions src/mito2/src/memtable/bulk/part.rs
Original file line number Diff line number Diff line change
@@ -170,15 +170,6 @@ impl BulkPartEncoder {
}
}

/// Loads metadata.
fn load_metadata(buf: &Bytes) -> Result<Arc<ParquetMetaData>> {
let options = ArrowReaderOptions::new()
.with_page_index(true)
.with_skip_arrow_metadata(true);
let metadata = ArrowReaderMetadata::load(buf, options).context(error::ReadDataPartSnafu)?;
Ok(metadata.metadata().clone())
}

/// Converts mutations to record batches.
fn mutations_to_record_batch(
mutations: &[Mutation],
2 changes: 2 additions & 0 deletions src/mito2/src/sst/parquet/row_group.rs
Original file line number Diff line number Diff line change
@@ -156,6 +156,8 @@ impl<'a> RowGroupBase<'a> {
.collect::<Vec<_>>()
}

/// Assigns uncompressed chunk binary data to [RowGroupBase::column_chunks]
/// and returns the chunk offset and binary data assigned.
pub(crate) fn assign_dense_chunk(
&mut self,
projection: &ProjectionMask,
2 changes: 1 addition & 1 deletion src/mito2/src/sst/parquet/stats.rs
Original file line number Diff line number Diff line change
@@ -27,7 +27,7 @@ use store_api::storage::ColumnId;
use crate::sst::parquet::format::ReadFormat;

/// Statistics for pruning row groups.
pub struct RowGroupPruningStats<'a, T> {
pub(crate) struct RowGroupPruningStats<'a, T> {
/// Metadata of SST row groups.
row_groups: &'a [T],
/// Helper to read the SST.

0 comments on commit 7d9d93e

Please sign in to comment.