Apply suggestions from code review

Co-authored-by: LFC <[email protected]>
GreptimeTeam · Mar 18, 2024 · 72dac1f · 72dac1f
1 parent 50f2e85
commit 72dac1f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/meta-srv/src/handler/failure_handler/runner.rs b/src/meta-srv/src/handler/failure_handler/runner.rs
@@ -151,7 +151,7 @@ impl FailureDetectRunner {
                         return;
                     }
                     Err(err) => {
-                        error!("Failed to check maintenance mode: {}", err);
+                        error!(err; "Failed to check maintenance mode");
                         return;
                     }
                 }

diff --git a/src/meta-srv/src/service/admin/maintenance.rs b/src/meta-srv/src/service/admin/maintenance.rs
@@ -62,13 +62,12 @@ impl MaintenanceHandler {
                 err_msg: "'enable' must be 'true' or 'false'",
             })?;
 
-        let req = PutRequest {
-            key: Vec::from(MAINTENANCE_KEY),
-            value: vec![],
-            prev_kv: false,
-        };
-
         let response = if enable {
+            let req = PutRequest {
+                key: Vec::from(MAINTENANCE_KEY),
+                value: vec![],
+                prev_kv: false,
+            };
             self.kv_backend
                 .put(req.clone())
                 .await
-Original file line number
+Diff line change
@@ Expand Up / @@ -151,7 +151,7 @@ impl FailureDetectRunner { @@
                             return;
                         }
                         Err(err) => {
-                            error!("Failed to check maintenance mode: {}", err);
+                            error!(err; "Failed to check maintenance mode");
                             return;
                         }
                     }
@@ Expand Down @@