feat: add logs for upgrading candidate region

GreptimeTeam · Jan 3, 2024 · 6f64ffe · 6f64ffe
1 parent 2e686fe
commit 6f64ffe
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/datanode/src/heartbeat/handler/upgrade_region.rs b/src/datanode/src/heartbeat/handler/upgrade_region.rs
@@ -14,7 +14,7 @@
 
 use common_error::ext::ErrorExt;
 use common_meta::instruction::{InstructionReply, UpgradeRegion, UpgradeRegionReply};
-use common_telemetry::warn;
+use common_telemetry::{info, warn};
 use futures_util::future::BoxFuture;
 use store_api::region_request::{RegionCatchupRequest, RegionRequest};
 
@@ -56,6 +56,7 @@ impl HandlerContext {
                 .try_register(
                     region_id,
                     Box::pin(async move {
+                        info!("Executing region: {region_id} catchup to: last entry id {last_entry_id:?}");
                         region_server_moved
                             .handle_request(
                                 region_id,

diff --git a/src/mito2/src/worker/handle_catchup.rs b/src/mito2/src/worker/handle_catchup.rs
@@ -16,10 +16,12 @@
 
 use std::sync::Arc;
 
+use common_telemetry::info;
 use snafu::ensure;
 use store_api::logstore::LogStore;
 use store_api::region_request::{AffectedRows, RegionCatchupRequest};
 use store_api::storage::RegionId;
+use tokio::time::Instant;
 
 use crate::error::{self, Result};
 use crate::region::opener::{replay_memtable, RegionOpener};
@@ -44,6 +46,7 @@ impl<S: LogStore> RegionWorkerLoop<S> {
 
         // Utilizes the short circuit evaluation.
         let region = if !is_mutable_empty || region.manifest_manager.has_update().await? {
+            info!("Reopening the region: {region_id}");
             let reopened_region = Arc::new(
                 RegionOpener::new(
                     region_id,
@@ -67,6 +70,8 @@ impl<S: LogStore> RegionWorkerLoop<S> {
         };
 
         let flushed_entry_id = region.version_control.current().last_entry_id;
+        info!("Trying to replay memtable for region: {region_id}");
+        let timer = Instant::now();
         let last_entry_id = replay_memtable(
             &self.wal,
             &region.wal_options,
@@ -75,6 +80,10 @@ impl<S: LogStore> RegionWorkerLoop<S> {
             &region.version_control,
         )
         .await?;
+        info!(
+            "Region: {region_id} catchup finished, elapsed: {:?}. last entry id: {last_entry_id}, expected: {:?}.",
+            request.entry_id, timer.elapsed()
+        );
         if let Some(expected_last_entry_id) = request.entry_id {
             ensure!(
                 expected_last_entry_id == last_entry_id,