fix: missing pre_write check on prometheus remote write (#4460)

fix: missing pre_write check on prometheus remote write
GreptimeTeam · Jul 30, 2024 · 567f510 · 567f510
1 parent 7896201
commit 567f510
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/frontend/src/instance/prom_store.rs b/src/frontend/src/instance/prom_store.rs
@@ -170,6 +170,10 @@ impl PromStoreProtocolHandler for Instance {
             .as_ref()
             .check_permission(ctx.current_user(), PermissionReq::PromStoreWrite)
             .context(AuthSnafu)?;
+        let interceptor_ref = self
+            .plugins
+            .get::<PromStoreProtocolInterceptorRef<servers::error::Error>>();
+        interceptor_ref.pre_write(&request, ctx.clone())?;
 
         let output = if with_metric_engine {
             let physical_table = ctx

diff --git a/src/servers/src/interceptor.rs b/src/servers/src/interceptor.rs
@@ -15,7 +15,7 @@
 use std::borrow::Cow;
 use std::sync::Arc;
 
-use api::prom_store::remote::{ReadRequest, WriteRequest};
+use api::prom_store::remote::ReadRequest;
 use api::v1::greptime_request::Request;
 use api::v1::RowInsertRequests;
 use async_trait::async_trait;
@@ -360,7 +360,7 @@ pub trait PromStoreProtocolInterceptor {
 
     fn pre_write(
         &self,
-        _write_req: &WriteRequest,
+        _write_req: &RowInsertRequests,
         _ctx: QueryContextRef,
     ) -> Result<(), Self::Error> {
         Ok(())
@@ -377,7 +377,11 @@ pub type PromStoreProtocolInterceptorRef<E> =
 impl<E: ErrorExt> PromStoreProtocolInterceptor for Option<PromStoreProtocolInterceptorRef<E>> {
     type Error = E;
 
-    fn pre_write(&self, write_req: &WriteRequest, ctx: QueryContextRef) -> Result<(), Self::Error> {
+    fn pre_write(
+        &self,
+        write_req: &RowInsertRequests,
+        ctx: QueryContextRef,
+    ) -> Result<(), Self::Error> {
         if let Some(this) = self {
             this.pre_write(write_req, ctx)
         } else {