Skip to content

Commit

Permalink
chore: remove a dbg! forget to remove (#3990)
Browse files Browse the repository at this point in the history
* chore: remove a dbg! forget to remove

* remove other dbg! and add lint

Signed-off-by: Ruihang Xia <[email protected]>

* fix pyo3 feature

Signed-off-by: Ruihang Xia <[email protected]>

---------

Signed-off-by: Ruihang Xia <[email protected]>
Co-authored-by: Ruihang Xia <[email protected]>
  • Loading branch information
discord9 and waynexia authored May 20, 2024
1 parent c50ff23 commit 533ada7
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 25 deletions.
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ license = "Apache-2.0"
[workspace.lints]
clippy.print_stdout = "warn"
clippy.print_stderr = "warn"
clippy.dbg_macro = "warn"
clippy.implicit_clone = "warn"
clippy.readonly_write_lock = "allow"
rust.unknown_lints = "deny"
Expand Down
2 changes: 1 addition & 1 deletion src/flow/src/expr/scalar.rs
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ impl TypedExpr {
})
.collect::<Result<Vec<_>, _>>()?;

Ok(dbg!(exprs))
Ok(exprs)
}
}

Expand Down
14 changes: 1 addition & 13 deletions src/script/src/python/ffi_types/pair_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -166,18 +166,10 @@ fn eval_rspy(case: CodeBlockTestCase) {
}
let code_obj = vm
.compile(&case.script, Mode::BlockExpr, "<embedded>".to_owned())
.map_err(|err| {
dbg!(&err);
vm.new_syntax_error(&err)
})
.map_err(|err| vm.new_syntax_error(&err))
.unwrap();
let result_vector = vm
.run_code_obj(code_obj, scope)
.map_err(|e| {
dbg!(&e);
dbg!(&case.script);
e
})
.unwrap()
.downcast::<PyVector>()
.unwrap();
Expand Down Expand Up @@ -211,10 +203,6 @@ fn eval_pyo3(case: CodeBlockTestCase) {
.unwrap()
.unwrap()
.extract::<PyVector>()
.map_err(|e| {
dbg!(&case.script);
e
})
.unwrap();
if !check_equal(res_vec.as_vector_ref(), case.expect.clone()) {
panic!(
Expand Down
1 change: 0 additions & 1 deletion src/script/src/python/pyo3/copr_impl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,6 @@ def a(cpu, mem, **kwargs):
&HashMap::from([("a".to_string(), "1".to_string())]),
&EvalContext::default(),
);
dbg!(&ret);
let _ = ret.unwrap();
}
}
1 change: 0 additions & 1 deletion src/script/src/python/rspython/builtins/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,6 @@ sin(values)"#,
}
Ok(obj) => {
let _ser = PyValue::from_py_obj(&obj, vm);
dbg!(_ser);
}
}
});
Expand Down
9 changes: 0 additions & 9 deletions src/script/src/python/rspython/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ def a(cpu, mem: vector[f64])->(vector[f64|None], vector[f64], vector[_], vector[
"#;
let pyast = parse(python_source, Mode::Interactive, "<embedded>").unwrap();
let copr = parse_and_compile_copr(python_source, None);
dbg!(copr);
}

#[test]
Expand Down Expand Up @@ -265,10 +264,6 @@ def calc_rvs(open_time, close):
"copr.py",
);
info!("{res}");
} else if let Ok(res) = ret {
dbg!(&res);
} else {
dbg!(ret);
}
}

Expand Down Expand Up @@ -311,9 +306,5 @@ def a(cpu, mem):
"copr.py",
);
info!("{res}");
} else if let Ok(res) = ret {
dbg!(&res);
} else {
dbg!(ret);
}
}

0 comments on commit 533ada7

Please sign in to comment.