refactor: check both lock and expire time, add more comments

GreptimeTeam · Dec 19, 2024 · 5074686 · 5074686
1 parent 22c628f
commit 5074686
Show file tree

Hide file tree

Showing 3 changed files with 172 additions and 214 deletions.
diff --git a/src/meta-srv/src/election/etcd.rs b/src/meta-srv/src/election/etcd.rs
@@ -282,12 +282,9 @@ impl Election for EtcdElection {
                 .compare_exchange(true, false, Ordering::Relaxed, Ordering::Relaxed)
                 .is_ok()
             {
-                if let Err(e) = self
-                    .leader_watcher
+                self.leader_watcher
                     .send(LeaderChangeMessage::StepDown(Arc::new(leader.clone())))
-                {
-                    error!(e; "Failed to send leader change message");
-                }
+                    .context(error::SendLeaderChangeSnafu)?;
             }
         }
 
@@ -342,12 +339,9 @@ impl EtcdElection {
             {
                 self.infancy.store(true, Ordering::Relaxed);
 
-                if let Err(e) = self
-                    .leader_watcher
+                self.leader_watcher
                     .send(LeaderChangeMessage::Elected(Arc::new(leader)))
-                {
-                    error!(e; "Failed to send leader change message");
-                }
+                    .context(error::SendLeaderChangeSnafu)?;
             }
         }