feat: add compaction request total count

GreptimeTeam · Oct 10, 2023 · 4b0261e · 4b0261e
1 parent b8c7fcd
commit 4b0261e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/mito2/src/metrics.rs b/src/mito2/src/metrics.rs
@@ -52,5 +52,7 @@ pub const WRITE_STAGE_ELAPSED: &str = "mito.write.stage_elapsed";
 pub const COMPACTION_STAGE_ELAPSED: &str = "mito.compaction.stage_elapsed";
 /// Timer of whole compaction task.
 pub const COMPACTION_ELAPSED_TOTAL: &str = "mito.compaction.total_elapsed";
+/// Counter of all requested compaction task.
+pub const COMPACTION_REQUEST_COUNT: &str = "mito.compaction.requests_total";
 /// Counter of failed compaction task.
 pub const COMPACTION_FAILURE_COUNT: &str = "mito.compaction.failure_total";
diff --git a/src/mito2/src/worker/handle_compaction.rs b/src/mito2/src/worker/handle_compaction.rs
@@ -13,11 +13,12 @@
 // limitations under the License.
 
 use common_telemetry::{error, info, timer};
+use metrics::increment_counter;
 use store_api::logstore::LogStore;
 use store_api::storage::RegionId;
 
 use crate::manifest::action::{RegionEdit, RegionMetaAction, RegionMetaActionList};
-use crate::metrics::{COMPACTION_STAGE_ELAPSED, STAGE_LABEL};
+use crate::metrics::{COMPACTION_REQUEST_COUNT, COMPACTION_STAGE_ELAPSED, STAGE_LABEL};
 use crate::request::{CompactionFailed, CompactionFinished, OnFailure, OptionOutputTx};
 use crate::worker::RegionWorkerLoop;
 
@@ -31,7 +32,7 @@ impl<S: LogStore> RegionWorkerLoop<S> {
         let Some(region) = self.regions.writable_region_or(region_id, &mut sender) else {
             return;
         };
-
+        increment_counter!(COMPACTION_REQUEST_COUNT);
         if let Err(e) = self.compaction_scheduler.schedule_compaction(
             region.region_id,
             &region.version_control,
@@ -59,7 +60,7 @@ impl<S: LogStore> RegionWorkerLoop<S> {
         };
 
         {
-            let _manifest_timer =
+            let manifest_timer =
                 timer!(COMPACTION_STAGE_ELAPSED, &[(STAGE_LABEL, "write_manifest")]);
             // Write region edit to manifest.
             let edit = RegionEdit {
@@ -73,6 +74,7 @@ impl<S: LogStore> RegionWorkerLoop<S> {
                 RegionMetaActionList::with_action(RegionMetaAction::Edit(edit.clone()));
             if let Err(e) = region.manifest_manager.update(action_list).await {
                 error!(e; "Failed to update manifest, region: {}", region_id);
+                manifest_timer.discard();
                 request.on_failure(e);
                 return;
             }