Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: JeremyHi <[email protected]>
  • Loading branch information
WenyXu and fengjiachun authored Sep 16, 2023
1 parent c17fe3a commit 4716208
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/datanode/src/datanode.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ pub struct Datanode {
opts: DatanodeOptions,
services: Option<Services>,
heartbeat_task: Option<HeartbeatTask>,
event_receiver: Option<RegionServerEventReceiver>,
region_event_receiver: Option<RegionServerEventReceiver>,
region_server: RegionServer,
greptimedb_telemetry_task: Arc<GreptimeDBTelemetryTask>,
}
Expand Down
4 changes: 2 additions & 2 deletions src/datanode/src/event_listener.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ pub enum RegionServerEvent {

pub trait RegionServerEventListener: Sync + Send {
/// Called *after* a new region was created/opened.
fn register_region(&self, _region_id: RegionId) {}
fn on_register_region(&self, _region_id: RegionId) {}

/// Called *after* a region was closed.
fn deregister_region(&self, _region_id: RegionId) {}
fn on_deregister_region(&self, _region_id: RegionId) {}
}

pub type RegionServerEventListenerRef = Box<dyn RegionServerEventListener>;
Expand Down

0 comments on commit 4716208

Please sign in to comment.