Skip to content

Commit

Permalink
chore: fix finish()
Browse files Browse the repository at this point in the history
  • Loading branch information
QuenKar committed Nov 16, 2023
1 parent 474bd5b commit 44a6591
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/datatypes/src/vectors/decimal.rs
Original file line number Diff line number Diff line change
Expand Up @@ -357,14 +357,9 @@ impl ScalarVectorBuilder for Decimal128VectorBuilder {
}

fn finish(&mut self) -> Self::VectorType {
// Arrow array builder will discard precision and scale information when finish.
// This behavior may not be reasonable.
Decimal128Vector {
array: self.mutable_array.finish(),
}
.with_precision_and_scale(self.precision, self.scale)
// unwrap is safe because we have checked the precision and scale in builder.
.unwrap()
}
}

Expand Down

0 comments on commit 44a6591

Please sign in to comment.