Skip to content

Commit

Permalink
apply review sugg
Browse files Browse the repository at this point in the history
Signed-off-by: Ruihang Xia <[email protected]>
  • Loading branch information
waynexia committed Nov 3, 2023
1 parent a2bc099 commit 2b6ef9d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
8 changes: 1 addition & 7 deletions src/metric-engine/src/engine.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ pub const METRIC_DATA_REGION_GROUP: RegionGroup = 0;
pub const METRIC_METADATA_REGION_GROUP: RegionGroup = 1;

const METADATA_SCHEMA_TIMESTAMP_COLUMN_NAME: &str = "ts";
const METADATA_SCHEMA_KEY_COLUMN_NAME: &str = "key";
const METADATA_SCHEMA_KEY_COLUMN_NAME: &str = "k";
const METADATA_SCHEMA_VALUE_COLUMN_NAME: &str = "val";

const METADATA_REGION_SUBDIR: &str = "metadata";
Expand Down Expand Up @@ -282,7 +282,6 @@ mod test {
inner: Arc::new(MetricEngineInner { mito }),
};
let engine_dir = env.data_home();
info!("[DEBUG] {engine_dir}");
let region_dir = join_dir(&engine_dir, "test_metric_region");

let region_id = RegionId::new(1, 2);
Expand All @@ -300,11 +299,6 @@ mod test {
.await
.unwrap();

let mut ls_result = tokio::fs::read_dir(&engine_dir).await.unwrap();
while let Some(dir) = ls_result.next_entry().await.unwrap() {
info!("[DEBUG] {dir:?}");
}

// assert metadata region's dir
let metadata_region_dir = join_dir(&region_dir, METADATA_REGION_SUBDIR);
let exist = tokio::fs::try_exists(region_dir).await.unwrap();
Expand Down
3 changes: 1 addition & 2 deletions src/mito2/src/engine.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ mod drop_test;
#[cfg(test)]
mod flush_test;
#[cfg(any(test, feature = "test"))]
#[cfg_attr(feature = "test", allow(unused))]
pub(crate) mod listener;
pub mod listener;
#[cfg(test)]
mod open_test;
#[cfg(test)]
Expand Down

0 comments on commit 2b6ef9d

Please sign in to comment.