Skip to content

Commit

Permalink
chore: add some comments to kafka
Browse files Browse the repository at this point in the history
  • Loading branch information
niebayes committed Dec 15, 2023
1 parent a6d04c2 commit 29cbacf
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/common/meta/src/wal/kafka.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,14 @@ use serde::{Deserialize, Serialize};

use crate::wal::kafka::topic::Topic;

/// Configurations for bootstraping a kafka wal.

Check warning on line 23 in src/common/meta/src/wal/kafka.rs

View workflow job for this annotation

GitHub Actions / Spell Check with Typos

"bootstraping" should be "bootstrapping".

Check warning on line 23 in src/common/meta/src/wal/kafka.rs

View workflow job for this annotation

GitHub Actions / Spell Check with Typos

"bootstraping" should be "bootstrapping".
#[derive(Clone, Debug, PartialEq, Serialize, Deserialize, Default)]
pub struct KafkaConfig;

/// Kafka wal options allocated to a region.
#[derive(Serialize, Deserialize, Default, Debug, Clone, PartialEq)]
pub struct KafkaWalOptions {
topic: Topic,
/// Kafka wal topic.
/// Publishers publish log entries to the topic while subscribers pull log entries from the topic.
pub topic: Topic,
}
2 changes: 2 additions & 0 deletions src/common/meta/src/wal/kafka/topic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/// Kafka wal topic.
// A topic is simply a string right now. But it may be more complex in the future.
pub type Topic = String;

0 comments on commit 29cbacf

Please sign in to comment.