Skip to content

Commit

Permalink
docs: leave a TODO for optimize param
Browse files Browse the repository at this point in the history
  • Loading branch information
killme2008 committed May 30, 2024
1 parent 4a2f7db commit 1999314
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/common/query/src/logical_plan.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ pub fn create_aggregate_function(
pub trait SubstraitPlanDecoder {
/// Decode the [`LogicalPlan`] from bytes with the [`CatalogProviderList`].
/// When `optimize` is true, it will do the optimization for decoded plan.
///
/// TODO(dennis): It's not a good design for an API to do many things.
/// The `optimize` was introduced because of `query` and `catalog` cyclic dependency issue
/// I am happy to refactor it if we have a better solution.
async fn decode(
&self,
message: bytes::Bytes,
Expand Down

0 comments on commit 1999314

Please sign in to comment.