fix: fix inconsistent cache

GreptimeTeam · Sep 19, 2023 · 0401f04 · 0401f04
1 parent f83b24e
commit 0401f04
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/src/common/meta/src/ddl/drop_table.rs b/src/common/meta/src/ddl/drop_table.rs
@@ -121,12 +121,13 @@ impl DropTableProcedure {
         };
 
         let cache_invalidator = &self.context.cache_invalidator;
+
         cache_invalidator
-            .invalidate_table_id(&ctx, self.data.table_id())
+            .invalidate_table_name(&ctx, self.data.table_ref().into())
             .await?;
 
         cache_invalidator
-            .invalidate_table_name(&ctx, self.data.table_ref().into())
+            .invalidate_table_id(&ctx, self.data.table_id())
             .await?;
 
         self.data.state = DropTableState::DatanodeDropRegions;

diff --git a/src/operator/src/statement/ddl.rs b/src/operator/src/statement/ddl.rs
@@ -123,12 +123,6 @@ impl StatementExecutor {
 
         let table = DistTable::table(table_info);
 
-        // Invalidates local cache ASAP.
-        self.cache_invalidator
-            .invalidate_table_id(&Context::default(), table_id)
-            .await
-            .context(error::InvalidateTableCacheSnafu)?;
-
         Ok(table)
     }
 
@@ -154,6 +148,11 @@ impl StatementExecutor {
             .await
             .context(error::InvalidateTableCacheSnafu)?;
 
+        self.cache_invalidator
+            .invalidate_table_name(&Context::default(), table_name.clone())
+            .await
+            .context(error::InvalidateTableCacheSnafu)?;
+
         Ok(Output::AffectedRows(1))
     }
 
@@ -262,6 +261,14 @@ impl StatementExecutor {
             .await
             .context(error::InvalidateTableCacheSnafu)?;
 
+        self.cache_invalidator
+            .invalidate_table_name(
+                &Context::default(),
+                TableName::new(catalog_name, schema_name, table_name),
+            )
+            .await
+            .context(error::InvalidateTableCacheSnafu)?;
+
         Ok(Output::AffectedRows(0))
     }