Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(kustomize): rename crd base directory #121

Merged
merged 1 commit into from
Dec 19, 2023
Merged

build(kustomize): rename crd base directory #121

merged 1 commit into from
Dec 19, 2023

Conversation

daviderli614
Copy link
Member

Fix following warning:

# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

@daviderli614 daviderli614 requested a review from zyy17 December 14, 2023 08:51
@zyy17 zyy17 changed the title chore: rename crd base directory build(kustomize): rename crd base directory Dec 19, 2023
zyy17
zyy17 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyy17 zyy17 merged commit 36c4715 into GreptimeTeam:develop Dec 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyy17 zyy17 zyy17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviderli614 @zyy17