Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds time zone setting for JDBC #988

Merged
merged 4 commits into from
May 29, 2024
Merged

feat: adds time zone setting for JDBC #988

merged 4 commits into from
May 29, 2024

Conversation

killme2008
Copy link
Contributor

What's Changed in this PR

Document for GreptimeTeam/greptimedb#3887

Related PR GreptimeTeam/greptimedb#4064

Checklist

  • Please ensure that the content in summary.yml matches the current document structure when you changed the document structure.
  • This change requires follow-up update in localized docs.

@killme2008 killme2008 requested review from nicecui and a team as code owners May 28, 2024 22:43
Copy link

cloudflare-workers-and-pages bot commented May 28, 2024

Deploying greptime-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a4ba478
Status: ✅  Deploy successful!
Preview URL: https://4ea7192e.greptime-docs.pages.dev
Branch Preview URL: https://feature-jdbc-timezone.greptime-docs.pages.dev

View logs

@@ -36,6 +36,8 @@ Use following connect string for your JDBC client.
jdbc:mysql://<host>:4002/<dbname>?user=<username>&password=<password>
```

Read the [time zone setting](/user-guide/client-libraries/java#time-zone) for JDBC.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Read the [time zone setting](/user-guide/client-libraries/java#time-zone) for JDBC.
Read the [time zone setting](https://docs.greptime.com/user-guide/client-libraries/java#time-zone) for JDBC.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to pin the latest version here? I suppose the same version should work?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These documents are displayed at https://greptime.cloud, so the internal links will not work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

docs/nightly/zh/greptimecloud/integrations/mysql.md Outdated Show resolved Hide resolved
docs/v0.8/en/greptimecloud/integrations/mysql.md Outdated Show resolved Hide resolved
docs/v0.8/zh/greptimecloud/integrations/mysql.md Outdated Show resolved Hide resolved
@nicecui nicecui merged commit 26461eb into main May 29, 2024
4 checks passed
@nicecui nicecui deleted the feature/jdbc-timezone branch May 29, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants