Skip to content

Commit

Permalink
Add ConfigureAwait whose purpose wasn't so clear. It has to be done s…
Browse files Browse the repository at this point in the history
…ince the call to OnCompleted ends up in ManualResetValueTaskSourceCore which does indeed care for the configuration.
  • Loading branch information
danielcweber committed Jan 8, 2025
1 parent 8f88a22 commit dd6200c
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/Providers.Core/Factory/WebSocketGremlinqClientFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,7 @@ public async IAsyncEnumerator<ResponseMessage<T>> GetAsyncEnumerator(Cancellatio
{
await using (ct.Register(Dispose))
{
//TODO: Should ConfigureAwait be called ?
#pragma warning disable CA2007 // Consider calling ConfigureAwait on the awaited task
if (await new ValueTask<ResponseAndQueueUnion<T>?>(this, 0) is { } union)
#pragma warning restore CA2007 // Consider calling ConfigureAwait on the awaited task
if (await new ValueTask<ResponseAndQueueUnion<T>?>(this, 0).ConfigureAwait(false) is { } union)
{
if (union.TryGetResponse(out var response))
yield return response;
Expand Down

0 comments on commit dd6200c

Please sign in to comment.