Review.

Gremlinq · Oct 29, 2019 · b2df9ac · b2df9ac
1 parent de53f6d
commit b2df9ac
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/Directory.build.props b/Directory.build.props
@@ -3,6 +3,7 @@
   <PropertyGroup>
     <PublicRelease>true</PublicRelease>
     <LangVersion>7.2</LangVersion>
+    <NoWarn>$(NoWarn);IDE1006</NoWarn>
   </PropertyGroup>
 
   <PropertyGroup Condition="!$(MSBuildProjectName.EndsWith('Tests')) AND !$(MSBuildProjectName.EndsWith('Tests.Entities')) AND !$(MSBuildProjectName.EndsWith('Samples'))" >

diff --git a/ExRam.Gremlinq.Core.Tests/GroovySerializationTest.cs b/ExRam.Gremlinq.Core.Tests/GroovySerializationTest.cs
@@ -1685,7 +1685,9 @@ public void Properties_Where_Dictionary_key1()
             _g
                 .V<Person>()
                 .Properties()
+#pragma warning disable 252,253
                 .Where(x => x.Properties["MetaKey"] == "MetaValue")
+#pragma warning restore 252,253
                 .Should()
                 .SerializeToGroovy("g.V().hasLabel(_a).properties().has(_b, _c)")
                 .WithParameters("Person", "MetaKey", "MetaValue");
@@ -1709,7 +1711,9 @@ public void Properties_Where_Id()
             _g
                 .V<Country>()
                 .Properties(x => x.Languages)
+#pragma warning disable 252,253
                 .Where(x => x.Id == "id")
+#pragma warning restore 252,253
                 .Should()
                 .SerializeToGroovy("g.V().hasLabel(_a).properties(_b).has(id, _c)")
                 .WithParameters("Country", "Languages", "id");
@@ -3449,7 +3453,9 @@ public void Where_outside_model()
             _g
                 .UseModel(GraphModel.FromBaseTypes<VertexWithStringId, EdgeWithStringId>())
                 .V()
+#pragma warning disable 252,253
                 .Where(x => x.Id == "hallo")
+#pragma warning restore 252,253
                 .Should()
                 .SerializeToGroovy("g.V().has(id, _a)");
         }

diff --git a/ExRam.Gremlinq.Core/Elements/VertexProperty.cs b/ExRam.Gremlinq.Core/Elements/VertexProperty.cs
@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Linq;
-using LanguageExt;
 using NullGuard;
 
 namespace ExRam.Gremlinq.Core.GraphElements

diff --git a/ExRam.Gremlinq.Core/Extensions/ObjectExtensions.cs b/ExRam.Gremlinq.Core/Extensions/ObjectExtensions.cs
@@ -1,13 +1,12 @@
-using System;
-using System.Collections.Concurrent;
+using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Linq;
 using System.Reflection;
 using System.Runtime.CompilerServices;
 using ExRam.Gremlinq.Core;
 
-namespace LanguageExt
+namespace System
 {
     internal static class ObjectExtensions
     {

diff --git a/ExRam.Gremlinq.Core/Extensions/TypeExtensions.cs b/ExRam.Gremlinq.Core/Extensions/TypeExtensions.cs
@@ -1,7 +1,6 @@
-using System;
-using System.Collections.Generic;
+using System.Collections.Generic;
 
-namespace LanguageExt
+namespace System
 {
     internal static class TypeExtensions
     {
@@ -14,4 +13,4 @@ public static IEnumerable<Type> GetTypeHierarchy(this Type type)
             }
         }
     }
-}
+}