Remove bucket name from object path prefix #62
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation is duplicating the bucket name in the object path prefix:
This PR removes the bucket name from the prefix, which was being unnecessarily added.
As a suggestion: I was thinking further on this and it would be nice to have a default path prefix definition that includes the db host and db name to avoid confusion in case one just decides to dump multiple database dumps into the same bucket without defining a prefix.
Something like:
STORAGE_S3_PREFIX / DB_HOSTNAME-DB_NAME / DUMP_ID
Where it would be possible to set another config value (ie.
STORAGE_S3_PATH
or some other naming to avoid confusion) to override theDB_HOSTNAME-DB_NAME
string.This would result in: