Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dinamically map and bind env vars #54

Merged
merged 3 commits into from
Apr 8, 2024
Merged

dinamically map and bind env vars #54

merged 3 commits into from
Apr 8, 2024

Conversation

joao-zanutto
Copy link
Contributor

@joao-zanutto joao-zanutto commented Apr 4, 2024 •
edited
Loading

  • Introduces build flag to dynamically unmarshall environment variables to Config

closes #48

@joao-zanutto joao-zanutto mentioned this pull request Apr 6, 2024
Closed
@joao-zanutto
Copy link
Contributor Author

@wwoytenko have u had the chance to take a look at my latest commit in this PR. I'm not entirely sure of the implications of removing the omitempty from the S3 Config struct, however, it solves #48

@wwoytenko wwoytenko self-requested a review April 8, 2024 16:22
@wwoytenko wwoytenko added the enhancement New feature or request label Apr 8, 2024
wwoytenko
wwoytenko approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@wwoytenko wwoytenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work!
LGTM.

@wwoytenko wwoytenko merged commit cf0ea76 into GreenmaskIO:main Apr 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwoytenko wwoytenko wwoytenko approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Env var values not being loaded without a config file definition
2 participants
@joao-zanutto @wwoytenko