move common.tmp_dir default value definition to viper #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwoytenko
requested changes
Apr 4, 2024
There was a problem hiding this comment.
Merge the actual main branch
Add into root.init() the next bunch of code ( skip - completed in #51 )
if err := viper.BindEnv("common.pg_bin_path", "COMMON_PG_BIN_PATH"); err != nil {
log.Fatal().Err(err).Msg("")
}UPD:
I have added a function in root.go registerEnvVars - add the tmp dir path as well. The COMMON_PG_BIN_PATH is not required anymore right now
|
#52 is merged |
|
Closing this PR as we chose to go another route |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #48
@wwoytenko please feel free to list other default values that should be added