Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add default definition for common.tmp_dir #44

Merged
merged 3 commits into from
Apr 1, 2024
Merged

add default definition for common.tmp_dir #44

merged 3 commits into from
Apr 1, 2024

Conversation

joao-zanutto
Copy link
Contributor

No description provided.

@wwoytenko wwoytenko self-requested a review April 1, 2024 12:56
wwoytenko
wwoytenko requested changes Apr 1, 2024
View reviewed changes
internal/domains/config.go Outdated Show resolved Hide resolved
wwoytenko
wwoytenko requested changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@wwoytenko wwoytenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! May I ask you for adding the information about default tmp dir in the documentation?

wwoytenko
wwoytenko approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@wwoytenko wwoytenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wwoytenko wwoytenko merged commit 14c8eb1 into GreenmaskIO:main Apr 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwoytenko wwoytenko wwoytenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joao-zanutto @wwoytenko