Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue with shared tables list in table graph #245

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

wwoytenko
Copy link
Contributor

@wwoytenko wwoytenko commented Nov 16, 2024

Closes #244

  • Fixed an issue where the table graph used a shared tables list, which was later sorted by the table size scoring function.
  • Added a regression test for RuntimeContext to ensure proper functionality.
  • Deleted commented code

@wwoytenko wwoytenko added the bug Something isn't working label Nov 16, 2024
@wwoytenko wwoytenko self-assigned this Nov 16, 2024
Closes #244

- Fixed an issue where the table graph used a shared tables list, which was later sorted by the table size scoring function.
- Added a regression test for RuntimeContext to ensure proper functionality.
- Deleted commented code

Co-authored-by: Jan Aagaard Meier <[email protected]>
@wwoytenko wwoytenko force-pushed the fix/tables-transformation-inharitance branch from 1bdf057 to fe3ca32 Compare November 16, 2024 11:36
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
20.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@wwoytenko wwoytenko merged commit 2838133 into main Nov 16, 2024
15 of 16 checks passed
wwoytenko added a commit that referenced this pull request Nov 16, 2024
@wwoytenko wwoytenko deleted the fix/tables-transformation-inharitance branch November 20, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weird bug: apply_for_references breaks under certain conditions
1 participant