Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Addressed bugs related to partitioned tables #241

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

wwoytenko
Copy link
Contributor

@wwoytenko wwoytenko commented Nov 12, 2024

Closes #238

  • Fixed an issue where the partitioned table itself was executed in the restore worker, resulting in a "file not found" error in storage. Closes bug: restoring partitioned tables fails #238.
  • Resolved an issue where Dump.createTocEntries processed partitioned tables as if they were physical entities, despite being logical.
  • Refined the findPartitionsOfPartitionedTable function for improved accuracy.
  • Corrected merging in the pre-data, data, and post-data sections, which previously caused a panic in dump command when the post-data section was excluded.
  • Added metadata about the first parent root table in the toolkit.Table struct.
  • Updated database schema metadata to include a root partition, which is necessary for performing --inserts during restoration.
  • Fixed an issue where dumps created with --load-via-partition-root did not use the root partition table in --inserts generation during restoration.
  • Revised a documentation example to ensure it aligns with table constraints.

Closes #238

* Resolved an issue where `Dump.createTocEntries` processed partitioned tables as if they were physical entities, despite being logical.
* Refined the `findPartitionsOfPartitionedTable` function for improved accuracy.
* Corrected merging in the pre-data, data, and post-data sections, which previously caused a panic in dump command when the post-data section was excluded.
* Added metadata about the first parent root table in the `toolkit.Table` struct.
* Updated database schema metadata to include a root partition, which is necessary for performing `--inserts` during restoration.
* Fixed an issue where dumps created with `--load-via-partition-root` did not use the root partition table in `--inserts` generation during restoration.
* Revised a documentation example to ensure it aligns with table constraints.
@wwoytenko wwoytenko added the bug Something isn't working label Nov 12, 2024
@wwoytenko wwoytenko self-assigned this Nov 12, 2024
@wwoytenko wwoytenko merged commit 470a33c into main Nov 12, 2024
15 checks passed
@wwoytenko wwoytenko deleted the fix/partitioned-table-related-issues branch November 20, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: restoring partitioned tables fails
1 participant