Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tool for installing keys #233

Merged
merged 16 commits into from
Nov 28, 2024
Merged

Added Tool for installing keys #233

merged 16 commits into from
Nov 28, 2024

Conversation

nicola02nb
Copy link
Contributor

@github-actions github-actions bot added gui Affects the Avalonia UI or translations. horizon Affects the Horizon OS HLE components. labels Nov 13, 2024
@nicola02nb
Copy link
Contributor Author

If you give a look to the code, I added two commented sections that may need to be implemented...

To set the correct directory where to save the keys:

public void InstallKeys(string keysSource)
{
string systemDirectory = AppDataManager.KeysDirPath;
//if(AppDataManager.Mode == AppDataManager.LaunchMode.UserProfile)
//{
// systemDirectory = AppDataManager.KeysDirPathUser;
//}
if (Directory.Exists(keysSource))

To check if the file content is correct:

private async Task HandleKeysInstallation(string filename)
{
try
{
//bool isValidKeysFilke = true;
//if (!isValidKeysFilke)
//{
// await ContentDialogHelper.CreateErrorDialog(LocaleManager.Instance.UpdateAndGetDynamicValue(LocaleKeys.DialogKeysInstallerKeysNotFoundErrorMessage, filename));
// return;
//}

@GreemDev
Copy link
Owner

This PR will not be merged until everything that needs to be implemented is.

@nicola02nb
Copy link
Contributor Author

Now it's all implemented, if you want to continue with the PR merge

@GabCoolDude
Copy link
Collaborator

Please add the locales lines to all the other locale files and not only to en_US.json

@nicola02nb
Copy link
Contributor Author

nicola02nb commented Nov 20, 2024

Can I keep them in english?

@GabCoolDude
Copy link
Collaborator

Yes, you're not expected to translate them into each language, just add them in the same place as you put them in en_US.json

@nicola02nb
Copy link
Contributor Author

Okok, I think it would be better if I do it after this PR and also #245 are megrd... I'm planning to fix also all other missing translations that are missing form translation files

@GabCoolDude
Copy link
Collaborator

I already have a PR for to add all the missing locales, it's #281. As for #245, I don't think it's getting merged anytime soon so you probably don't have to worry about that

@nicola02nb
Copy link
Contributor Author

Oh, I hadn't seen them...

I'll commit soon missing translations

@nicola02nb
Copy link
Contributor Author

Done

@GabCoolDude GabCoolDude linked an issue Nov 20, 2024 that may be closed by this pull request
@ryzendew
Copy link

Tested this PR on 3 distros: Fedora 41 Pikaos 4 aka Debian and Cachyos

No issues at all with installing keys!

Good work!

@mattzink
Copy link

Should the "Install Keys" menu item be moved above the "Install Firmware" item, since that is the required order of operations? Might help newbies.

@jzumaran
Copy link
Contributor

Tested this on Mac OS 13.6.9 and had no issues installing keys. Tried all 3 methods and in all cases keys were installed into ~ /Library/Application Suppor/Ryujinx/system.

@GreemDev GreemDev merged commit 346dfe9 into GreemDev:master Nov 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui Affects the Avalonia UI or translations. horizon Affects the Horizon OS HLE components.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Gui install keys button
6 participants