Translokator spatial grid rendering #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The grids now update accordingly when editing their properties, they also update when enabling a grid.
Kamzik123
changed the title
Greavesy1899
requested changes
Dec 6, 2024
| @@ -573,6 +573,49 @@ private void CompileData() | |||
| #endregion encode instance data / build grid | |||
| } | |||
|
|
|||
| public void RebuildGridData() | |||
There was a problem hiding this comment.
Is there a chance that some of this code now has overlap with CompileData? Is it worth creating some private util functions to main consistency?
|
|
||
| namespace Rendering.Core | ||
| { | ||
| public class TranslokatorSpatialGrid |
There was a problem hiding this comment.
Is there a reason as to why this doesn't use primitive instancing with the boxes using the primitive batch manager?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: