Fix line wrapping in sidecar default configs for filebeat #21043
+13
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AntonEbel, do you have any idea why this was broken? I'm pretty sure the configs were tested when they were added. Also, I only tested the Darwin configs. It would be great if you could give the other configs a quick test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sidecar default configuration templates for filebeat have the line wrapping messed up. For new clusters, or clusters that don't have the default templates present, invalid configuration will be created. See the following preview:
This PR fixes that by modifying the templates for newly created configurations. After applying the PR, the default configuration from above should look like this:
However, this won't fix existing configurations.