Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preflight check for usable space and cache size #21031

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

todvora
Copy link
Contributor

@todvora todvora commented Nov 22, 2024

This PR is adding a datanode preflight check comparing the usable disk space and the setting of node search cache. Recently, there were several complains that datanodes are running out of space and it was not clear why. This preflight check will either terminate the startup if the cache consumes all of the usable space or warn if the cache is over 80% of the space.

With this, users should get better overview and an action recommendation in case the datanode is running on very limited storage and the cache could cause problems with watermark levels inside opensearch.

How Has This Been Tested?

Added unit tests, existing set of integration tests for valid startups.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora marked this pull request as ready for review November 25, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant