Fix custom highlighting of field values in the message details of the message table widget. 6.1
#21005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: this PR is a backport of #20921 for
6.1.Description
Motivation and Context
Before this change the highlighting of field values in the message details of the message table widget was broken.
This happened because the whole field row (
dt) was wrapped withCustomHighlight. As a result the font color got applied for both the field name and value. The background color also got applied for the whole row, but was not visible because of the related DOM structure.For dark highlight colors a light font color will be generated and the row looked empty.
This PR is fixing the issue by only wrapping the field value with
CustomHighlight.I tested this change with decorators and extended our e2e tests.
Fixes: #18388