-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature palo alto 11x #20236
Feature palo alto 11x #20236
Conversation
@danotorrey @kingzacko1 the Loginsoft team has set up a palo alto test instance on their VPN to test this with. Muthu has shared the credentials and connection/setup instructions for us to use, which I put into a 1password entry under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this PR up @Nithin-Kasam! The code is looking good, I've just added a few minor comments.
I'm working to get set up to test this then I'll circle back to finish reviewing.
@@ -0,0 +1,4 @@ | |||
type="a" | |||
message="Added new Palo Alto version 11 input to ingest PAN OS 11 logs and parse via illuminate." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave off the part about Illuminate so users know this input can be used without it.
message="Added new Palo Alto version 11 input to ingest PAN OS 11 logs and parse via illuminate." | |
message="Added new Palo Alto version 11 input to ingest PAN OS 11 logs." |
@Override | ||
public void launch(InputBuffer buffer) throws MisfireException { | ||
super.launch(buffer); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be dropped since we're just calling the superclass method.
@Override | |
public void launch(InputBuffer buffer) throws MisfireException { | |
super.launch(buffer); | |
} |
FYI @danotorrey @kingzacko1 for testing this I threw together a branch off the python log generator repo with the logs provided by Muthu. The main branch is also has a wealth of other PAN logs that can be used too: https://github.com/Graylog2/generate-gl-data/pull/49 |
@Nithin-Kasam just a heads up I pushed 2 small changes we discussed with the content team to help with eventual parsing and log handling:
We are hoping to finalize review of this this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @Nithin-Kasam! This is looking good to me. I have requested a few smaller changes. @kingzacko1 and I are working on testing this out and will report back with the results.
...g2-server/src/test/java/org/graylog/integrations/inputs/paloalto11/PaloAlto11xCodecTest.java
Outdated
Show resolved
Hide resolved
graylog2-server/src/main/java/org/graylog/integrations/inputs/paloalto11/PaloAlto11xCodec.java
Outdated
Show resolved
Hide resolved
graylog2-server/src/main/java/org/graylog/integrations/inputs/paloalto11/PaloAlto11xCodec.java
Outdated
Show resolved
Hide resolved
graylog2-server/src/main/java/org/graylog/integrations/inputs/paloalto11/PaloAlto11xCodec.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed up fixes for my PR comments. The rest LGTM. I am good with merging once the smoke test is successful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tests successfully!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tests successfully with the latest!
Description
Added new input palo alto v11 to pull PAN OS 11 logs which contains some schema changes and additions.
Motivation and Context
This input contains base parsing of logs,then parsing will happen through illuminate for better parsing.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: