750 allow orders to be viewed #777
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a problem where non-super-admins cannot view an order once it's been submitted. - Update the controller to check if the current user is allowed to view the order chosen when they are not allowed to edit the order. - Add a permission check for viewing an order. - Add a show view to the orders views. - Update several partials to only display buttons that can modify the order and not when the user can only view the order. - Add some test cases and fixtures to verify the function of Users::OrderManipulator.
Ensure correct templates rendered and redirects based on user.
If user calls edit action but is not allows to edit, redirects to show action (order_path(@order)) Show action shows if user is allowed, otherwise redirects to index action (orders_path) routes for orders resource now excludes only :destroy action
Shows logic inherent in permissions, moves logic based on status to private method. This passes rubocop's length rules while keeping the necessary logic in front
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #750