Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated a year picker #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zangarmarsh
Copy link

The year picker is accessible by clicking onto the month name. Maybe it would worth add an option to create it conditionally.

@GramThanos
Copy link
Owner

We have to make some changes so that it does not affect themes and that it is contained inside the layout of the calendar.
Maybe I have to help you port this to an extension.

@zangarmarsh
Copy link
Author

zangarmarsh commented May 21, 2021

Hello @GramThanos . As you wish. I thought it would be a fundamental feature that needed to be integrated in the core library since it's great to have the chance to pick the year from a calendar. If you'd rather port this as extension it's ok; otherwise, feel free to fix it to resolve collisions with themes. Let me know.

@GramThanos
Copy link
Owner

GramThanos commented May 21, 2021 via email

@mjesteve
Copy link

Hi, I found this great component not long ago and have integrated it into my Apache Royale projects. I would be very interested to know if the "year selection" is going to be integrated (maybe it is already integrated and I didn't know how to use it).
Have you thought about doing the same with the months?

Thank you.
Hiedra.

@GramThanos
Copy link
Owner

Hey, I will look into that and come back to you.

@mjesteve
Copy link

Thank you very much for your attention. I really like jscalendar, I was able to create a Medium Theme without any problem: sizes, colours,... that's very important for me as my goal is to make it look completely integrated in Royale.
I'm going to open an issue to ask the community about a problem I have, maybe someone with more experience than me with js can guide me to solve it.

I'll be attentive to your comments.

Thanks again.
Hiedra

@Neustradamus
Copy link

Any news on it?

@GramThanos
Copy link
Owner

I have neglected this project. I do plan to update it, but not right now. Hopefully on the next version release I will also create a guide for the extension API thus all the updates could be added as an extension.

@mjesteve
Copy link

mjesteve commented Nov 3, 2022

I will be watching :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants