-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated a year picker #59
base: master
Are you sure you want to change the base?
Conversation
We have to make some changes so that it does not affect themes and that it is contained inside the layout of the calendar. |
Hello @GramThanos . As you wish. I thought it would be a fundamental feature that needed to be integrated in the core library since it's great to have the chance to pick the year from a calendar. If you'd rather port this as extension it's ok; otherwise, feel free to fix it to resolve collisions with themes. Let me know. |
I don't know :P
Maybe you are right.
I will have a look at it and give it some thought.
…On Fri, May 21, 2021, 10:33 AM zangarmarsh ***@***.***> wrote:
Hello @GramThanos <https://github.com/GramThanos> . As you wish. I
thought it would be a good and fundamental feature that needed to be
integrated in the core library. If you think it's better to port this as
extension it's ok; otherwise, feel free to fix it to resolve collisions
with themes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADRLVT4Q276NWPYKGIPSNDLTOYEDVANCNFSM45C4655Q>
.
|
Hi, I found this great component not long ago and have integrated it into my Apache Royale projects. I would be very interested to know if the "year selection" is going to be integrated (maybe it is already integrated and I didn't know how to use it). Thank you. |
Hey, I will look into that and come back to you. |
Thank you very much for your attention. I really like jscalendar, I was able to create a Medium Theme without any problem: sizes, colours,... that's very important for me as my goal is to make it look completely integrated in Royale. I'll be attentive to your comments. Thanks again. |
Any news on it? |
I have neglected this project. I do plan to update it, but not right now. Hopefully on the next version release I will also create a guide for the extension API thus all the updates could be added as an extension. |
I will be watching :) |
The year picker is accessible by clicking onto the month name. Maybe it would worth add an option to create it conditionally.